Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce async alternatives in the client command hierarchy #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pevogam
Copy link
Contributor

@pevogam pevogam commented Mar 21, 2023

TODO: Consider best approach here and in the topmost nonblocking reading.

@pevogam
Copy link
Contributor Author

pevogam commented Mar 21, 2023

@ldoktor This is just a very drafty idea and I am just curious about your opinion in general and for alternatives in case there are obvious one I have definitely missed.

pevogam added 2 commits March 28, 2023 07:50
TODO: Consider best approach here and in the topmost nonblocking
reading and whether there is enough demand for this extension.
TODO: Is shorter or longer timeout in the new location better?
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @pevogam, it looks nice, I wouldn't be oppose to this, but I wouldn't benefit of it either. I played with asyncio briefly a while ago and found out it's not useful for tasks I'm using aexpect for (I liked it's usage in interactive games, looked clear there, but with regards to testing it seems too strict to not-really-educated me)

So my main question would be, do you plan to or know someone who would be using this API and would be willing to address potential issues?

@lmr @clebergnu what are your opinions?

@pevogam
Copy link
Contributor Author

pevogam commented Apr 3, 2023

Hello @pevogam, it looks nice, I wouldn't be oppose to this, but I wouldn't benefit of it either. I played with asyncio briefly a while ago and found out it's not useful for tasks I'm using aexpect for (I liked it's usage in interactive games, looked clear there, but with regards to testing it seems too strict to not-really-educated me)

So my main question would be, do you plan to or know someone who would be using this API and would be willing to address potential issues?

Indeed there is a background for the idea - a remote test spawner introduced in avocado-framework/avocado#5621 that makes use of aexpect. There are however ways to do it also without aexpect having asyncio capabilities but you can see the earlier commits there for an example.

@lmr @clebergnu what are your opinions?

Feel free to compare with the pull request too regarding use cases for some source of details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants